Scheduled Downtime
On Tuesday 24 October 2023 @ 5pm MT the forums will be in read only mode in preparation for the downtime. On Wednesday 25 October 2023 @ 5am MT, this website will be down for maintenance and expected to return online later in the morning.
Normal Operations
The forums are back online with normal operations. If you notice any issues or errors related to the forums, please reach out to help@ucar.edu

FSURDAT and DGVM

Sorry, it's just I've been going over this module line by line for a month now and I have been referring to the tech des and dev guide as well to trace what's going on in the module as well as how it interfaces with other modules. I have write statements in as well to debug and I do think I understand what this module does, except for that question about fpc_total_new.

My question was not so much about what this is for but about how the concept translates to code and the logic behind it - the tech description says that trees should not exceed 95% of a veg land unit. Yet, in the code, the check for this, fpc_total_new(g)>0.95 uses an fpc_total_new that was computed by adding the new fpcgrid's within the loop that adds new saplings. From my reading of the code, this loop does not include the units where they are trees in conditions enough for survival but not for establishment. So I don't think fpc_total_new really is the total of all trees when it is being compared against 0.95.

I was hoping you would remember why the code was written this way but if this is all actually is beyond the user support that can be offered as per NCAR's policy, I understand.
 

slevis

Moderator
Unfortunately I do not remember the logic behind the particular loop. You seem to have studied the code enough now to know it better than I do. If there's something you dislike about it, you should try changing it and look at the effect. You may improve the results.

Sam
 
Top