Issue with Adding irrigation_method to histfile in CTSM

[bixby]

Hello CTSM community,

I have recently applied the changes from Add flood irrigation and surface water ponding for rice paddies by YiYaoVUB · Pull Request #2026 · ESCOMP/CTSM on GitHub to my CTSM setup and the model seems to run smoothly.
However, I am keen on inspecting the newly introduced variable irrigation_method (source: Yao et al., 2022) in the surfdata_map and wish to add it to the histfile for further analysis.

To achieve this, I utilized call hist_addfld2d for the addition.
Although the variable was successfully added to the histfile, the resulting values seem to be off.
I have experimented with both avgflag options 'A' and 'I', and tried using ptr_col, gcell, lnd, and patch

(I personally believe ptr_lnd is the correct choice, as in surfrdMod.F90 the dimension name is set as dim1name=grlnd:

if ( cft_size > 0 )then
call ncd_io(ncid=ncid, varname='irrigation_method', flag='read', data=irrig_method, &
dim1name=grlnd, readvar=readvar)

For reference and to possibly aid in troubleshooting, I am attaching the resulting histfiles, the surfdata_map file, and the modified IrrigationMod.F90.

I would greatly appreciate any insights or suggestions on how to correctly implement and analyze the irrigation_method variable in the histfile.

Thank you in advance for your help!

 

[sacks]

Note that that PR has been superseded by Implementation of irrigation stream file by YiYaoVUB · Pull Request #2102 · ESCOMP/CTSM . We are not generally able to provide user support for not-yet-integrated PRs, but if you feel there might be an issue with the PR that should be addressed there, then we would welcome you to comment in the PR.